Skip to content

Create Envs, a factory for making mock Envs #2442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 5, 2025
Merged

Create Envs, a factory for making mock Envs #2442

merged 9 commits into from
May 5, 2025

Conversation

webmaster128
Copy link
Member

@webmaster128 webmaster128 commented Mar 26, 2025

A potential solution for #2218. Not necessarily ready yet but I wonder if this looks good.

Closes #2218

@webmaster128 webmaster128 requested a review from chipshort March 26, 2025 15:09
Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea! That way we could even extend it if we need more configurability in the future.

@webmaster128 webmaster128 marked this pull request as ready for review April 7, 2025 12:25
@chipshort chipshort self-requested a review April 23, 2025 12:39
@webmaster128 webmaster128 force-pushed the envs branch 2 times, most recently from 9b5caf0 to b35b235 Compare April 28, 2025 16:16
Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!

Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could you add a changelog entry?

@webmaster128
Copy link
Member Author

Sure, added (last commit)

Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@webmaster128 webmaster128 merged commit fcbd69f into main May 5, 2025
42 checks passed
@webmaster128 webmaster128 deleted the envs branch May 5, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create mock_env() alternative that supports non-default address generators (aka. other bech32 prefixes)
2 participants