Create Envs, a factory for making mock Envs#2442
Merged
webmaster128 merged 9 commits intomainfrom May 5, 2025
Merged
Conversation
chipshort
reviewed
Apr 7, 2025
Contributor
chipshort
left a comment
chipshort
left a comment
There was a problem hiding this comment.
Nice idea! That way we could even extend it if we need more configurability in the future.
webmaster128
force-pushed
the
envs
branch
2 times, most recently
from
9b5caf0 to
b35b235
Compare
chipshort
reviewed
May 2, 2025
Contributor
chipshort
left a comment
chipshort
left a comment
There was a problem hiding this comment.
Looks good. Could you add a changelog entry?
…in_id configurable
Member
Author
|
Sure, added (last commit) |
chipshort
reviewed
May 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A potential solution for #2218. Not necessarily ready yet but I wonder if this looks good.
Closes #2218